Skip to content

Conversation

@oliveira-julio
Copy link
Contributor

the indentation was wrong, using only one space instead of 4.

@npostavs
Copy link
Contributor

But what about the # NOTE: Use minimum indentation, because Emacs 25+ doesn't dedent docstrings.? (I'm pretty sure I wrote that note, but I don't recall the exact details right now)

@oliveira-julio
Copy link
Contributor Author

the indentation was not a multiple of four.
the snippet function_docstring_numpy has the correct indentation.
function_docstring is now with the same indentation.

@oliveira-julio
Copy link
Contributor Author

I use Emacs 25.3.1, and the docstring is working.

@npostavs
Copy link
Contributor

I use Emacs 25.3.1, and the docstring is working.

Did you check with python-indent-offset set to 2 (as described in joaotavora/yasnippet#750)?

@oliveira-julio
Copy link
Contributor Author

:O plot twist, function_docstring_numpy is wrong.

@oliveira-julio oliveira-julio changed the title Fix indentation python-mode/function_docstring Fix indentation python-mode/function_docstring_numpy Feb 24, 2018
@oliveira-julio
Copy link
Contributor Author

thanks @npostavs for the patience ^^ .

@AndreaCrotti AndreaCrotti merged commit 2b4c4d7 into AndreaCrotti:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants