Skip to content

Conversation

@kktlnx
Copy link
Contributor

@kktlnx kktlnx commented Oct 9, 2018

My first commit to "real" repo ever, so maybe isn't good enough.

@AndreaCrotti
Copy link
Owner

Well I'm honored you chose this project for your first real "PR" then ;)

I'll have a look shortly

# name: puts
# key: puts
# --
puts(${1:string});
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a great fan of snippets with only one thing to expand, in this case it would only really save one keystroke (the (), and maybe the ";" at the end.

# name: strlen
# key: strlen
# --
strlen(${1:string});
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing here, unless we maybe shorten it (but not sure how it would be shortened) I would not include such trivial snippets

@AndreaCrotti
Copy link
Owner

AndreaCrotti commented Oct 12, 2018

A few extra comments, FYI we also have cc-mode which is a parent of c-mode, and a few others like:

snippets/c-mode/.yas-parents
1:cc-mode

snippets/c++-mode/.yas-parents
1:cc-mode

snippets/csharp-mode/.yas-parents
1:cc-mode

These snippets seem C specific though so maybe it's fine this way.

@AndreaCrotti AndreaCrotti self-assigned this Oct 12, 2018
@kktlnx
Copy link
Contributor Author

kktlnx commented Oct 13, 2018

I'll remember about single arg snippets ;-) (I deleted these ones)
Thank You for extra comments.

I'am newbie with C and Emacs, so I will be adding c snippets gradually, if they are useful.

@AndreaCrotti
Copy link
Owner

Cool thanks!

@AndreaCrotti AndreaCrotti merged commit 88e2099 into AndreaCrotti:master Oct 20, 2018
@AndreaCrotti
Copy link
Owner

Your changes will go to Melpa tomorrow already and to Melpa stable as soon as I do another release (in the next few weeks probably)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants