Skip to content

Improvements and fixes for React & Redux snippets #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 6, 2020
Merged

Improvements and fixes for React & Redux snippets #359

merged 10 commits into from
Jun 6, 2020

Conversation

@sei40kr
Copy link
Contributor

@sei40kr sei40kr commented Dec 25, 2019 •
edited
Loading

Description

  • Remove legacy React snippets:
    • SFC without arrow function
    • Unsafe React component methods
  • Fix TM_FILENAME_BASE in some snippets

@AndreaCrotti
Copy link
Owner

AndreaCrotti commented Jan 22, 2020 •
edited
Loading

I don't know much about react/redux but I'll do my best to review.
One question though @sei40kr , these legacy snippets you are removing, can't they still be useful to someone using an older version of react maybe?

Or it's unlikely that anyone would still need them?

@AndreaCrotti AndreaCrotti merged commit e5ebfcd into AndreaCrotti:master Jun 6, 2020
@AndreaCrotti
Copy link
Owner

AndreaCrotti commented Jun 6, 2020

I had another look and it looks good to me, thanks @sei40kr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sei40kr @AndreaCrotti