Rename read_url to read_link #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes ContextKit to avoid
from contextkit import *producing a name collision by importing its tool functionread_url, which collides with SolveIt's built-in, automatically importedread_urltool function. It addresses #11It produces the following effect:
read_linkwhich is equal to the oldread_urland which is imported byimport *read_urlfrom theimport *list, but leaves it there so it can still be imported directly by nameread_url. (In a later version, we remove it entirely.)This change breaks backward compatibility by removing
read_urlfrom theimport *list. Any code depending on that line to get access toread_url, which upgrades to a version which includes this PR, will crash.I'm very open to suggestions regarding ways to avoid this or handle the situation more graciously, while still achieving the goal of avoiding the name collision with SolveIt's
read_url. I don't see any obvious choices.