Skip to content

Conversation

@RensDimmendaal
Copy link
Contributor

This PR renames dependency PyPDF2 to pypdf as the maintainers moved that package.
This move will silence the deprecation warning that's currently shown when using contextkit.

.venv/lib/python3.12/site-packages/PyPDF2/init.py:21: DeprecationWarning: PyPDF2 is deprecated. Please move to the pypdf library instead.

See: https://pypi.org/project/PyPDF2/

@RensDimmendaal RensDimmendaal requested a review from algal June 2, 2025 07:31
@algal
Copy link
Contributor

algal commented Jun 2, 2025

This looks straightforward and obviously correct to me. Any thoughts @Isaac-Flath ?

@Isaac-Flath
Copy link
Contributor

LGTM.

Unrelated to this PR, but we should probably fix tests or turn them off. Looks like they've been broken for a while.

Copy link
Contributor

@algal algal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. It works. I added a commit to bump the version, to spare consumers the confusion having two different versions with the same declared number but different behavior.

@algal
Copy link
Contributor

algal commented Jun 3, 2025

I bumped the version number so we can cut a new PyPi release. @RensDimmendaal or @Isaac-Flath , please give me a hand pushing a new release to PyPi. We need to do a bit of a dance for that, iirc.

@RensDimmendaal
Copy link
Contributor Author

@algal I think we need the pypi token for it. Do you have that?

Otherwise it's maybe @jph00 who needs to complete this step.

https://nbdev.fast.ai/tutorials/tutorial.html#upload-to-pypi

@Isaac-Flath
Copy link
Contributor

@RensDimmendaal - I just invited @algal as an owner on the pypi project. I'm happy to add you as well if you give me your pypi username

@RensDimmendaal
Copy link
Contributor Author

RensDimmendaal commented Jun 3, 2025 via email

@jph00
Copy link
Contributor

jph00 commented Jun 3, 2025

@algal the current version in settings.ini doesn't seem to have been bumped. To bump the version number, run nbdev_bump_version. BTW I recommend running this immediately after you do a release. That way, the current version number in dev is higher than the released version number, which is what you want. Lemme know if you want a hand with anything. Happy to do the release when ready. Note that you need to do a github release as well, not just a pypi release. Steps:

  • Ensure all PRs and issues in this release are labeled "enhancement" or "bug"
  • Run nbdev_release_gh and edit the auto-generated (from github labels) changelog as desired
  • Save/close that, and say "y" when asked if you want to release
  • Run nbdev_pypi && nbdev_bump_version && commit bump (assuming you have twine installed and configured correctly)

Lemme know if anyone would like a mini tutorial sometime.

@algal algal added the enhancement New feature or request label Jun 5, 2025
@algal algal merged commit 6f49b36 into main Jun 5, 2025
0 of 2 checks passed
@algal
Copy link
Contributor

algal commented Jun 5, 2025

@jph00 @RensDimmendaal This change has been merged and pushed to PyPi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants