-
Notifications
You must be signed in to change notification settings - Fork 3
pypdf2 has moved to pypdf #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This looks straightforward and obviously correct to me. Any thoughts @Isaac-Flath ? |
|
LGTM. Unrelated to this PR, but we should probably fix tests or turn them off. Looks like they've been broken for a while. |
algal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. It works. I added a commit to bump the version, to spare consumers the confusion having two different versions with the same declared number but different behavior.
|
I bumped the version number so we can cut a new PyPi release. @RensDimmendaal or @Isaac-Flath , please give me a hand pushing a new release to PyPi. We need to do a bit of a dance for that, iirc. |
|
@algal I think we need the pypi token for it. Do you have that? Otherwise it's maybe @jph00 who needs to complete this step. https://nbdev.fast.ai/tutorials/tutorial.html#upload-to-pypi |
|
@RensDimmendaal - I just invited @algal as an owner on the pypi project. I'm happy to add you as well if you give me your pypi username |
|
Thanks! Just made an account. `rensdimmendaal`
Rens Dimmendaal
***@***.***>
…On Tue, Jun 3, 2025 at 5:39 AM Isaac Flath ***@***.***> wrote:
*Isaac-Flath* left a comment (AnswerDotAI/ContextKit#7)
<#7 (comment)>
@RensDimmendaal <https://github.com/RensDimmendaal> - I just invited
@algal <https://github.com/algal> as an owner on the pypi project. I'm
happy to add you as well if you give me your pypi username
—
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACK7SS6ZTXGAY6ZXWO2PQI33BUKIXAVCNFSM6AAAAAB6MG74R2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMZTGI4DONBTHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@algal the current version in settings.ini doesn't seem to have been bumped. To bump the version number, run
Lemme know if anyone would like a mini tutorial sometime. |
|
@jph00 @RensDimmendaal This change has been merged and pushed to PyPi. |
This PR renames dependency
PyPDF2topypdfas the maintainers moved that package.This move will silence the deprecation warning that's currently shown when using contextkit.
See: https://pypi.org/project/PyPDF2/