Skip to content

Conversation

@hamelsmu
Copy link
Contributor

This closes #106

@hamelsmu
Copy link
Contributor Author

@sgugger I can open a separate PR, the original purpose of these raw tags were to escape liquid in notebooks which were causing things to break, especially in code cells.

I can make a separate PR if you wish to target code cells only, this fixes the problem for now

@sgugger
Copy link

sgugger commented Mar 20, 2020

Escaping them in code cells sounds fine to me, if you don't mind doing a separate PR. Ideally it would be nice to know what things are broken so we escape those specifically.

@sgugger sgugger merged commit dfcdd32 into AnswerDotAI:master Mar 20, 2020
@hamelsmu
Copy link
Contributor Author

The things that are broken is when people try to put {{ in their code, which for example is common if someone is using Keras callbacks to format stuff. I don't think there is any way around it except to escape the code block for liquid

@sgugger
Copy link

sgugger commented Mar 20, 2020

Ok, so the fix sounds right then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inline images aren't being displayed on nbdev.fast.ai

2 participants