Skip to content

Bugfix/schiltz3/add class role #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2022
Merged

Bugfix/schiltz3/add class role #83

merged 1 commit into from
Dec 28, 2022

Conversation

@schiltz3
Copy link
Collaborator

@schiltz3 schiltz3 commented Dec 27, 2022

Fix attempting to assign class role on every poll

Adding a new class role was outside the correct if block for the class poll. This fix moves the addNewRole call inside the corresponding if block

Link to github card

closes #82

Changes

  • Move function call into if block

@schiltz3 schiltz3 requested a review from nathen418 December 27, 2022 02:01
@schiltz3 schiltz3 self-assigned this Dec 27, 2022
@schiltz3 schiltz3 changed the base branch from main to staging December 27, 2022 02:01
@nathen418 nathen418 enabled auto-merge December 27, 2022 17:19
@schiltz3 schiltz3 disabled auto-merge December 27, 2022 22:31
@schiltz3 schiltz3 merged commit 83e64fd into staging Dec 28, 2022
@schiltz3 schiltz3 deleted the bugfix/schiltz3/add-class-role branch December 28, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nathen418 nathen418 nathen418 approved these changes

Assignees

@schiltz3 schiltz3

Labels

Bug Fix

Projects

CSSC-Bot Project Board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Bot attempts to assign class role every time a poll is interacted with

3 participants

@schiltz3 @nathen418