Make OFF_T_PF less flaky #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIZEOF_OFF_Tis a macro that is not defined. This means the use ofOFF_T_PFcan be flaky which can lead to incorrect value parsing. For example:leads to
Rather than define this macro, this change forces the use of a 64-bit integer via
PRIu64or%lluto support larger range requests. In my testing this makes request range parsing much more robust.