Use email address instead of session id to identify users#221
Merged
nlake44 merged 2 commits intoAppScale:testingfrom Jan 2, 2013
Merged
Conversation
Contributor
There was a problem hiding this comment.
Please doc this function and any others where you made significant changes.
ghost
assigned
Contributor
|
Code looks good minus some of the functions can use a doc string. Requires a demo before being merged in and to be done. |
Contributor
|
Make sure to clear the old data session, but otherwise demo was good. |
nlake44
added a commit
that referenced
this pull request
Jan 2, 2013
…_for_token Use email address instead of session id to identify users
nlake44
added a commit
to nlake44/appscale
that referenced
this pull request
Sep 30, 2013
…or-run-instances Not injecting flag for run-instances if the value was set to False
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #220 by refactoring the AppLoadBalancer to use e-mail addresses when creating and getting tokens instead of the Rails session ID. The problem was that, in certain deployments (including VirtualBox), the session ID was nil, causing a SOAPFaultError when contacting the UserAppServer (which was expecting a string and not nil).
Tested on a one node deployment on VirtualBox, and on EC2.