Skip to content

Fix ShardKeys property by using collection type instead of string. #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2021
Merged

Fix ShardKeys property by using collection type instead of string. #315

merged 1 commit into from
Jun 10, 2021

Conversation

@DiscoPYF
Copy link
Collaborator

fix #313

@DiscoPYF DiscoPYF requested a review from a team March 12, 2021 21:49
@DiscoPYF
Copy link
Collaborator Author

DiscoPYF commented Apr 3, 2021

There is a failing test. I will investigate.

@DiscoPYF DiscoPYF force-pushed the fix-shardKeys branch 2 times, most recently from 188cc80 to c2824d7 Compare April 18, 2021 14:10
@DiscoPYF
Copy link
Collaborator Author

Thanks for reviewing @modios , merging now. 👍

@DiscoPYF DiscoPYF merged commit d549e9b into ArangoDB-Community:master Jun 10, 2021
@DiscoPYF DiscoPYF deleted the fix-shardKeys branch June 10, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@modios modios modios approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ShardKeys in PostCollectionBody should be a collection instead of string

2 participants

@DiscoPYF @modios