Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions screenpro/assays/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import pandas as pd
import anndata as ad
import scanpy as sc
from typing import Literal

from ..phenoscore import (
runPhenoScore, getPhenotypeData,
Expand Down Expand Up @@ -65,6 +66,8 @@ def _calculateGrowthFactor(self, untreated, treated, db_rate_col):
pd.DataFrame: growth factor dataframe
"""
adat = self.adata.copy()
if 'condition' not in adat.obs.columns or 'replicate' not in adat.obs.columns:
raise ValueError("The 'condition' and 'replicate' columns self.adata.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a missing word here, right?

growth_factors = []
# calculate growth factor for gamma, tau, or rho score per replicates
for replicate in adat.obs.replicate.unique():
Expand Down Expand Up @@ -197,17 +200,27 @@ def calculateDrugScreenDESeq(self, untreated, treated, t0=None, run_name='pyDESe
)
self._add_phenotype_results(run_name, f'rho:{rho_name}', rho)

def calculateDrugScreen(self, score_level, untreated, treated, t0=None, db_rate_col='pop_doubling', run_name=None, **kwargs):
def calculateDrugScreen(self, score_level: Literal["compare_reps", "compare_guides"], untreated: str, treated: str, t0: str=None, db_rate_col: str='pop_doubling', run_name: str=None, count_filter_threshold: int=40, count_filter_type: Literal['mean', 'both', 'either']='mean', **kwargs):
"""
Calculate `gamma`, `rho`, and `tau` phenotype scores for a drug screen dataset in a given `score_level`.
Calculate `gamma`, `rho`, and `tau` phenotype scores for a drug screen dataset in a given `score_level`. This function
is a wrapper around runPhenoScore. Check the args of runPhenoScore carefully before using it.

For a given phenotype score, runPhenoScore implements a count filter threshold. By default this threshold changes
any guide or target whose mean count across replicates being compared is <40 to NAs. Because this can lead to
unexpected behavior when the user relies on filterLowCounts, we specify both the count_filter_threshold and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also remove filterLowCounts if it's confusing. I had it in previous versions and it's not necessary to keep it. What do you think?

count_filter_type arguments of runPhenoScore explicitly here.

self.adata.obs must have a 'condition' column. If doubling infomation is provided, it also needs a 'replicate' column.

Args:
score_level (str): name of the score level
score_level (str): name of the score level. Must be "compare_reps" or "compare_guides"
untreated (str): name of the untreated condition
treated (str): name of the treated condition
t0 (str): name of the untreated condition
db_rate_col (str): column name for the doubling rate, default is 'pop_doubling'
run_name (str): name for the phenotype calculation run
count_filter_threshold (int): filter threshold for counts across compared replicates. Default is 40.
count_filter_type (str): type of filter for counts across replicates. Default is 'mean.'
**kwargs: additional arguments to pass to runPhenoScore
"""
if not run_name: run_name = score_level
Expand Down Expand Up @@ -256,6 +269,8 @@ def calculateDrugScreen(self, score_level, untreated, treated, t0=None, db_rate_
self.adata, cond_ref=untreated, cond_test=tr, growth_rate=db_diff,
n_reps=self.n_reps,
test=self.test, score_level=score_level,
count_filter_threshold=count_filter_threshold,
count_filter_type=count_filter_type,
**kwargs
)
self._add_phenotype_results(run_name, f'rho:{rho_name}', rho)
Expand Down
3 changes: 3 additions & 0 deletions screenpro/phenoscore/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ def runPhenoScore(adata, cond_ref, cond_test, score_level, var_names='target', t
"""
adat = adata.copy()

if 'condition' not in adat.obs.columns:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for now, thanks for adding this as a more clear error message. We may change it in future so runPhenoScore can take "condition" as an input.

raise ValueError("The AnnData object must have a 'condition' column in its obs.")

# format result name
result_name = f'{cond_test}_vs_{cond_ref}'
print(f'\t{cond_test} vs {cond_ref}')
Expand Down