-
Notifications
You must be signed in to change notification settings - Fork 0
Enhanced Catalogue Browser #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sync-up PR (Jun Han)
Sync-up PR (Jun Han)
Prakhar896
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very well-written, the user experience is much improved as well. Just a few things to look at for my comments. Can you also do me a favour and, in a comment under this PR, describe and document all the different things going on when it comes to responsiveness, arrow keys, skeleton placeholders, and all the other features in detail?
Component Summary
|
Summary Table
|
Prakhar896
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What was done in this PR
Improved Content Sliding Animation
Refined the animation logic for smoother and more consistent content transitions.
Image Loading Experience
Integrated the
<Skeleton>component to display a placeholder while images are loading, enhancing perceived performance.Keyboard Navigation Enhancements
CatalogueItemView.Section.Mobile Experience Improvements
Arrow Overlay Optimization
Removed the arrow overlay component from mobile view to reduce visual clutter and improve UX.
Chevron Double-Click Bug Fix
Fixed a bug where double-clicking chevrons in
CatalogueItemViewcaused it to skip two items instead of one.