-
Notifications
You must be signed in to change notification settings - Fork 0
Added metadata displaying in Catalogue Browser and static UI for Data Studio #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…in english metadata display
Prakhar896
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More general comments:
- In
cardComponent.jsx, don't create the unnecessaryisLoadingvariable. Use!isImageLoadedwhere required directly. - Why do all the very odd
imageSrcstorage and then usage? Implement the source in the respective<Image>components themselves. TheimageSrcevaluation in arbitrary state data might not expose changes to artefact information to React, leading to potentially missed render cycles or abnormal<Image>loading behaviour. - Your state handling for
CatalogueItemView.jsxassumes uniqueness for thetitleattribute. This could potentially lead to issues. I suggest changing the state to rely onitemIndexbased rendering for the artefact details. - Great work with the rendering of NER data and conditional MM/HF metadata rendering.
- Do keep in mind recent discussions and developments when fixing this PR, as the comments may be outdated
Overall, incredibly impressive work and effort in achieving the ambitious user experience! 🔥
…fetching catalogue data
Prakhar896
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor fix to make
Prakhar896
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What was done in this PR
ArrowOverlayaccept an optionalsmallerparameter to render smaller navigation arrows in scrollable sections.CardItemcomponent to accept optional boolean parametersexpandableanddescriptionDisplayto control expandability and description visibility.selectedTitleprop fromMMSectionandSectioncomponents for cleaner interfaces.MetadataDisplaycomponent that conditionally renders different types of metadata for artefacts, including OCR text with entity highlighting and figure captions with headshots.ItemGrid: A grid of draggable cards with placeholder data, usingdnd-kit’suseDraggablehook.ItemGroups: A list of droppable groups that accept dragged items, usinguseDroppableand visual feedback on hover.GroupCard: Cards representing collections (Books, Categories, Batch) with truncated descriptions and nested item sections.GroupItemsSection: A horizontally scrollable container with arrow overlays for group items thumbnails.GroupToggle: A segmented control toggle to switch between different group views (Books, Categories, Batch) with icons and active state highlighting.DataStudiopage.DataStudiomain page with drag-and-drop workspace.ArtefactEditorpage to edit individual artefacts. (currently no logic, only accepts artefact ID in the URL and displays it)GroupViewpage for viewing collections and artefacts. (currently no logic, only accepts group and artefact ID in the URL and displays it)PublicGallerywith clearer frontend data processing usingJSONResponse, Toast notifications and fixes for redundant state declarations.