Skip to content

Conversation

@JunHammy
Copy link
Contributor

@JunHammy JunHammy commented Aug 1, 2025

What was done in this PR

  1. Made ArrowOverlay accept an optional smaller parameter to render smaller navigation arrows in scrollable sections.
  2. Updated CardItem component to accept optional boolean parameters expandable and descriptionDisplay to control expandability and description visibility.
  3. Removed unused selectedTitle prop from MMSection and Section components for cleaner interfaces.
  4. Added MetadataDisplay component that conditionally renders different types of metadata for artefacts, including OCR text with entity highlighting and figure captions with headshots.
  5. Created a static UI for the Data Studio feature, including:
    • ItemGrid: A grid of draggable cards with placeholder data, using dnd-kit’s useDraggable hook.
    • ItemGroups: A list of droppable groups that accept dragged items, using useDroppable and visual feedback on hover.
    • GroupCard: Cards representing collections (Books, Categories, Batch) with truncated descriptions and nested item sections.
    • GroupItemsSection: A horizontally scrollable container with arrow overlays for group items thumbnails.
    • GroupToggle: A segmented control toggle to switch between different group views (Books, Categories, Batch) with icons and active state highlighting.
    • Integration of drag-and-drop logic in DataStudio page.
  6. Added new pages and routing support for:
    • DataStudio main page with drag-and-drop workspace.
    • ArtefactEditor page to edit individual artefacts. (currently no logic, only accepts artefact ID in the URL and displays it)
    • GroupView page for viewing collections and artefacts. (currently no logic, only accepts group and artefact ID in the URL and displays it)
  7. Improved error handling and data fetching in PublicGallery with clearer frontend data processing using JSONResponse, Toast notifications and fixes for redundant state declarations.
  8. General UI improvements for responsiveness and consistency across catalogue and data studio components.

@JunHammy JunHammy requested a review from Prakhar896 August 1, 2025 10:12
@JunHammy JunHammy self-assigned this Aug 1, 2025
@JunHammy JunHammy added the enhancement New feature or request label Aug 1, 2025
Copy link
Contributor

@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More general comments:

  • In cardComponent.jsx, don't create the unnecessary isLoading variable. Use !isImageLoaded where required directly.
  • Why do all the very odd imageSrc storage and then usage? Implement the source in the respective <Image> components themselves. The imageSrc evaluation in arbitrary state data might not expose changes to artefact information to React, leading to potentially missed render cycles or abnormal <Image> loading behaviour.
  • Your state handling for CatalogueItemView.jsx assumes uniqueness for the title attribute. This could potentially lead to issues. I suggest changing the state to rely on itemIndex based rendering for the artefact details.
  • Great work with the rendering of NER data and conditional MM/HF metadata rendering.
  • Do keep in mind recent discussions and developments when fixing this PR, as the comments may be outdated

Overall, incredibly impressive work and effort in achieving the ambitious user experience! 🔥

@JunHammy JunHammy requested a review from Prakhar896 August 9, 2025 13:26
Copy link
Contributor

@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fix to make

@JunHammy JunHammy requested a review from Prakhar896 August 9, 2025 15:11
Copy link
Contributor

@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prakhar896 Prakhar896 merged commit b1465b8 into main Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants