Add a helper function to get the location ID from an inputted name #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I messed up the javadoc comment oops |
Contributor
Author
|
fixed the issue |
cjmang
requested changes
Oct 12, 2025
cjmang
reviewed
Oct 12, 2025
Co-authored-by: PlatanoBailando <13842799+cjmang@users.noreply.github.com>
cjmang
approved these changes
Oct 12, 2025
Collaborator
|
Ah well, it doesn't compile now, might have an extra paren. |
Contributor
Author
|
will try locally |
Contributor
Author
|
@cjmang should be fixed, there was an extra paren that IntelliJ caught |
cjmang
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a helper function to abstract getting a location ID from a name if you're making a generic client like https://github.com/benny-dreamly/ArchipelagoMusicClient that can't really bundle the data package of all the clients inside itself. It also adds a docstring that makes it obvious that you should only use this if you understand the implications of it. (I'm not sure if the doctoring is correct, but I copied what I had seen in the past)