Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copter: circle mode can't point vehicle at center if CIRCLE_RATE > ATC_SLEW_YAW #21098

Closed
rmackay9 opened this issue Jul 2, 2022 · 4 comments · Fixed by #22720
Closed

Copter: circle mode can't point vehicle at center if CIRCLE_RATE > ATC_SLEW_YAW #21098

rmackay9 opened this issue Jul 2, 2022 · 4 comments · Fixed by #22720

Comments

@rmackay9
Copy link
Contributor

rmackay9 commented Jul 2, 2022

As discovered in this discussion if the CIRCLE_RATE is higher than ATC_SLEW_YAW then the vehicle's yaw will not be able to keep pointed at the circle's center. Most of the time the CIRCLE_RATE is much lower than the ATC_SLEW_YAW so this hasn't been noticed before.

We should probably do one of the following:

  1. add a note to the CIRCLE_RATE parameter description <-- I think I like this idea best
  2. limit the CIRCLE_RATE to be no more than ATC_SLEW_YAW (I'm not a fan of this idea)
  3. print a warning to the user when they enter circle mode for the first time that CIRCLE_RATE is too high
  4. add a pre-arm check in the parameter section
@timtuxworth
Copy link
Contributor

timtuxworth commented Jul 2, 2022

Number 4 (as a warning or pre-arm blocking error) could be implemented in Lua script - so can be enabled/disabled without being baked into the firmware. I have a draft PR for this concept here #20930

@mohitkenia7
Copy link

Hi
I want to work on this

@mohit-marathe
Copy link

Hey @rmackay9, I'm new here and want to work on this issue. Can you help me with where I should get started?

@ConnectBhawna
Copy link

Hii,
I am working on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment