-
Notifications
You must be signed in to change notification settings - Fork 17.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_ToshibaCAN: add support for Toshiba CAN ESC #10249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this go in before or after KDE CAN ?
Txs for the help on this PR. I think I've addressed the issues found.
rebased and squashed. We will do one final flight test tomorrow that everything is still working OK. |
This is rebased on master (which includes the KDECAN changes) and has also been tested on a real vehicle and confirmed to work so I'll merge shortly... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
This PR adds support for the Toshiba CAN ESCs and includes some changes from @OXINARF's KDECAN PR.
Manufacturer product page is here (including video) and here (Japanese only sorry)
This driver has been both bench tested and flight tested on a real vehicle. There are some known potential issues:
Below are some relevant bits of the datasheet. The ESCs don't have a "discovery" feature. Instead the user toggles some dip switches to tell each ESC what it's number is.