Copter: make PosHold state member variables; remove some redundant na… #10443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm afraid this will conflict with the 2nd set of spool changes from lthall, bnsgeyer and I |
peterbarker
force-pushed
the
pr/poshold-members
branch
from
21c0123
to
27ac068
Compare
peterbarker
force-pushed
the
pr/poshold-members
branch
from
27ac068
to
decc386
Compare
This was simply moving the members from the poshold struct into the class then mechanically removing poshold. from in front of the member access.
This adds some type-safety and helps distinguish between the many defines which are used within PosHold mode Saves about 210 bytes of flash
peterbarker
force-pushed
the
pr/poshold-members
branch
from
decc386
to
7ed76d9
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mespacing