AP_Math: move location_passed_point and line_path_proportion to Location #11062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
reviewed
Apr 9, 2019
| @@ -55,7 +55,7 @@ static void test_passed_waypoint(void) | |||
| struct Location loc = location_from_point(test_points[i].location); | |||
| struct Location wp1 = location_from_point(test_points[i].wp1); | |||
| struct Location wp2 = location_from_point(test_points[i].wp2); | |||
| if (location_passed_point(loc, wp1, wp2) != test_points[i].passed) { | |||
| if (loc.passed_line_point(wp1, wp2) != test_points[i].passed) { | |||
There was a problem hiding this comment.
This has bugged me for a long time.
It's past, not passed!
There was a problem hiding this comment.
ok so I go for past_line_point ?
There was a problem hiding this comment.
yes, it should be past_point or past_line_point I think.
|
@peterbarker done ! |
peterbarker
previously requested changes
Apr 12, 2019
|
I have compile on scripting ... but not test as I don't know how it works |
|
@khancyr I pushed in a large change to scripting so you will need to rebase to fix the changes. The good news though is that if you look in master basically all the code you were trying to edit disappeared form that file, and moved into a generated file, which doesn't use passed point at all :) |
|
correct rebase |
|
looks like its all merged now, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
location_passed_point was rename to passe_line_point, any other suggestion ?