Copter: merge ArduCopter.cpp and Copter.cpp #11453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks |
OXINARF
approved these changes
May 31, 2019
| osd.set_nav_info(nav_info); | ||
| } | ||
| #endif | ||
|
|
||
| /* | ||
| constructor for main Copter class | ||
| */ |
There was a problem hiding this comment.
Nitpicking: I would put the constructor as the first thing on the file.
There was a problem hiding this comment.
I put it down where we created the instance of it on purpose.
@rmackay9 - preferences?
| * ..and many more. | ||
| * | ||
| * Code commit statistics can be found here: https://github.com/ArduPilot/ardupilot/graphs/contributors | ||
| * Wiki: http://copter.ardupilot.org/ |
There was a problem hiding this comment.
Not holding this PR at all, but we should likely start a CONTRIBUTORS.md file, probably based on the allcontributors.org spec.
peterbarker
force-pushed
the
pr/copter-content-move
branch
from
f301826
to
58ff5e5
Compare
|
On the dev call we decided that this was a good change for all vehicles but it's up to the vehicle maintainers to decide when they should implement this in order to reduce havoc with outstanding PRs. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.