AP_NMEA_Output: skip sending sentences if no space on UART #12426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OXINARF
previously requested changes
Sep 27, 2019
AP_NMEA_Output: clean scope by removing unneeded temps AP_NMEA_Output: redo last_sent to last_run AP_NMA_Output: early-exit if no data
peterbarker
force-pushed
the
pr/nmea-westerly
branch
from
066ff2c
to
20ff4e6
Compare
peterbarker
dismissed
OXINARF’s stale review
asprintf return code handling corrected
|
review showed there is an existing bug in use of snprintf and null term for the lat/lon strings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been tested in SITL and Randy had it on a vehicle.