-
Notifications
You must be signed in to change notification settings - Fork 17.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_NavEKF3/AP_VisualOdom/SITL: add support for vision-speed-estimates #14404
Conversation
9e3cc7c
to
3969e90
Compare
Here's a flight video test of this PR |
@@ -251,6 +251,12 @@ const AP_Param::GroupInfo SITL::var_info3[] = { | |||
// vicon yaw error in degrees (added to reported yaw sent to vehicle) | |||
AP_GROUPINFO("VICON_YAWERR", 19, SITL, vicon_yaw_error, 0), | |||
|
|||
// vicon message type mask |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be nice for vicon params to be in a child table
3969e90
to
29f2a2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main issue is the lack of accuracy information being passed via this interface. If unavailable from the sensor, then it should be set to a default or parameter defined value in the sensor driver.
Use of specified minimum GPS velocity error to set observation noise for this sensor type should be avoided.
A recommended improvement is to apply the position offset correction to the delayed data immediately after it is retrieved from the buffer rather than apply it separately in the fusion and reset operations.
Hi @rmackay9 I do some changes address @priseborough 's comments in #14368. Could you be able to take a look? Thank you very much I do some flight test and it looks well. |
be9e54f
to
f807cae
Compare
7a0a181
to
ff6f360
Compare
This has been rebased on @chobitsfan's PR #14368 |
Co-authored-by: Randy Mackay <rmackay9@yahoo.com>
SIM_VICON_TMASK controls which of the 3 supported messages are sent SIM_VICON_VGLI_X/Y/Z allows introducing a velocity glitch
ff6f360
to
488631b
Compare
488631b
to
d48b5cb
Compare
Rebased on master and two commits added to address requests from @priseborough. |
This is built on top of PR #14368 from @chobitsfan (this original PR should be merged first).
This PR has the following enhancements (on top of the older PR):
Some non-blocking issues:
Testing done so far:
Some more SITL and actual flight tests (using EKF3) will be completed before merging