add support for checked register in Invensensev2 Driver #14823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugobliterator
force-pushed
the
pr-checked_reg_invv2
branch
2 times, most recently
from
72aa908
to
7bb4a60
Compare
|
Here is the Flight log using the firmware built over this PR. |
tridge
requested changes
Jul 29, 2020
bugobliterator
force-pushed
the
pr-checked_reg_invv2
branch
2 times, most recently
from
c220502
to
d51bad2
Compare
|
Hi @tridge I have added the support for devops using banks for SPI sensors only: Also tested by modifying the register using the same, and I get correct behaviour. |
bugobliterator
force-pushed
the
pr-checked_reg_invv2
branch
2 times, most recently
from
d91e04d
to
4254e1c
Compare
bugobliterator
force-pushed
the
pr-checked_reg_invv2
branch
from
4254e1c
to
b2cd9aa
Compare
|
pending CI, then merge |
Passed CI; merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for checked register setup for bank based addressing setups, like the one employed in Invensensev2 Driver.
The Logic trace is attached herewith for anyone to look. The contains data on the SPI bus on IMU board in CubeOrange, the sensor comms were disabled by pulling up the CS pin of the Invensensev2 sensor. Will also upload the flight test results as soon as done
Download Logic Data Trace