-
Notifications
You must be signed in to change notification settings - Fork 17k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GPSB logging regression in ArduCopter 4.0 #15205
Fix GPSB logging regression in ArduCopter 4.0 #15205
Conversation
Works in hardware and causes no regressions on CI. |
464290b
to
c3a80e2
Compare
@peterbarker had a better PR, so I backported it. |
@peterbarker CI tests pass, but does the Copter-4.0 branch support instance numbers in log messages? |
c3a80e2
to
b2b5123
Compare
Can this be merged now? |
"GPS2", GPS_FMT, GPS_LABELS, GPS_UNITS, GPS_MULTS }, \ | ||
{ LOG_GPSB_MSG, sizeof(log_GPS), \ | ||
"GPSB", GPS_FMT, GPS_LABELS, GPS_UNITS, GPS_MULTS }, \ | ||
"GPS", "QBBIHBcLLeffffB", "TimeUS,I,Status,GMS,GWk,NSats,HDop,Lat,Lng,Alt,Spd,GCrs,VZ,Yaw,U", "s#---SmDUmnhnh-", "F----0BGGB000--" }, \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for a stable 4.0 release I think it would be better to use the old GPSB msg, not the instance numbers, so it doesn't break tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced by #16524
This fixes a regression introduced in 4.0
I do not have the time right now to do a CI test for this, I did test it on real hardware