Fix GPSB logging regression in ArduCopter 4.0 #15205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works in hardware and causes no regressions on CI. |
amilcarlucas
force-pushed
the
pr-fix-gpsb-logging-4.0
branch
from
464290b
to
c3a80e2
Compare
|
@peterbarker had a better PR, so I backported it. |
|
@peterbarker CI tests pass, but does the Copter-4.0 branch support instance numbers in log messages? |
amilcarlucas
changed the title
amilcarlucas
force-pushed
the
pr-fix-gpsb-logging-4.0
branch
from
c3a80e2
to
b2b5123
Compare
|
Can this be merged now? |
tridge
requested changes
Jan 13, 2021
| "GPS2", GPS_FMT, GPS_LABELS, GPS_UNITS, GPS_MULTS }, \ | ||
| { LOG_GPSB_MSG, sizeof(log_GPS), \ | ||
| "GPSB", GPS_FMT, GPS_LABELS, GPS_UNITS, GPS_MULTS }, \ | ||
| "GPS", "QBBIHBcLLeffffB", "TimeUS,I,Status,GMS,GWk,NSats,HDop,Lat,Lng,Alt,Spd,GCrs,VZ,Yaw,U", "s#---SmDUmnhnh-", "F----0BGGB000--" }, \ |
There was a problem hiding this comment.
for a stable 4.0 release I think it would be better to use the old GPSB msg, not the instance numbers, so it doesn't break tools
There was a problem hiding this comment.
Replaced by #16524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in 4.0
I do not have the time right now to do a CI test for this, I did test it on real hardware