Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_CanManager: use milliseconds for timeout #16243

Merged
merged 1 commit into from Jan 11, 2021

Conversation

peterbarker
Copy link
Contributor

The use of PRIu64 was breaking people's builds

@peterbarker
Copy link
Contributor Author

@bugobliterator was there a reason this was using micros?

@bugobliterator
Copy link
Member

The use of PRIu64 was breaking people's builds

This was added by @OXINARF . But yeah I don't see a reason for this.

@OXINARF
Copy link
Member

OXINARF commented Jan 6, 2021

I don't remember anymore why I used micros there. However, I think this isn't going to fix it since there are other PRI* macros in there. In my opinion, the fix should be to include the cinttypes header as my original code does.

The use of PRIu64 was breaking people's builds
@peterbarker
Copy link
Contributor Author

I don't remember anymore why I used micros there. However, I think this isn't going to fix it since there are other PRI* macros in there. In my opinion, the fix should be to include the cinttypes header as my original code does.

Nuked the extra uses of PRI* - thanks.

I am tempted to just make the include as least-possible-fix, mind you.

This current PR will save 4 bytes per ESC....

Hmmm.

@OXINARF
Copy link
Member

OXINARF commented Jan 6, 2021

Yeah, this is included in the normal builds now (my original code was basically the entire firmware), so space should be a concern.

I still prefer the appropriate prints rather than the casts 😜

@tridge
Copy link
Contributor

tridge commented Jan 11, 2021

using PRIu64 is correct, but hard to read. Discussed on the call, decided to approve

@tridge tridge merged commit 96981ba into ArduPilot:master Jan 11, 2021
@peterbarker peterbarker deleted the pr/kdecan-timeout-ms branch January 12, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants