Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autotest to weed out default-values in default files #16332

Merged
merged 4 commits into from
Jan 18, 2021

Conversation

peterbarker
Copy link
Contributor

A lot of fames are specifying EKF2 in their files where that's the default.

When we move to EKF3 by default that's a problem.

This tool does run on the other vehicle types, but the changes to their defaults are extensive so I've chosen to do a separate PR for those.

This new test is disabled at the moment but can be run with: ./Tools/autotest/autotest.py --gdb --debug build.Copter test.Copter.FrameDefaults

@peterbarker peterbarker force-pushed the pr/default-frame-params branch 3 times, most recently from 167d389 to 37675eb Compare January 18, 2021 02:55
@peterbarker
Copy link
Contributor Author

Most of the Copter frames are spitting the equivalent of this out:

Loaded 70 parameters from /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm
Loaded 1 parameters from /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter-dodecahexa.parm
AT-0112.2: Frame (dodeca-hexa) failed:
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (1.000000) in (FS_THR_ENABLE) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (5.000000) in (COMPASS_OFS_X) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (13.000000) in (COMPASS_OFS_Y) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (-18.000000) in (COMPASS_OFS_Z) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (5.000000) in (COMPASS_OFS2_X) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (13.000000) in (COMPASS_OFS2_Y) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (-18.000000) in (COMPASS_OFS2_Z) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (5.000000) in (COMPASS_OFS3_X) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (13.000000) in (COMPASS_OFS3_Y) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (-18.000000) in (COMPASS_OFS3_Z) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (1500.000000) in (RC1_TRIM) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (1500.000000) in (RC2_TRIM) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (1500.000000) in (RC3_TRIM) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (1500.000000) in (RC4_TRIM) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (1500.000000) in (RC5_TRIM) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (1500.000000) in (RC6_TRIM) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (1500.000000) in (RC7_TRIM) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (1500.000000) in (RC8_TRIM) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (0.000000) in (FLTMODE6) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (0.000000) in (INS_ACC3OFFS_X) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (0.000000) in (INS_ACC3OFFS_Y) and in firmware
AT-0112.2:         /home/pbarker/rc/ardupilot/Tools/autotest/default_params/copter.parm has same value (0.000000) in (INS_ACC3OFFS_Z) and in firmware

@tridge
Copy link
Contributor

tridge commented Jan 18, 2021

we really need to add proper support for downloading defaults, preferably via ftp. The key would be to handle the ones where we do set_default()

@tridge
Copy link
Contributor

tridge commented Jan 18, 2021

this is only for sitl params, right? For non-SITL we have a problem that SITL and non-SITL may have different defaults

@peterbarker
Copy link
Contributor Author

@tridge yes, this is for the SITL parameters represented in vehicleinfo.py.

I've considered augmenting this to look at all of the files in Tools/Frame_params - but we don't even know what vehicle they're for, which would slow that down somewhat :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants