-
Notifications
You must be signed in to change notification settings - Fork 17.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autotest to weed out default-values in default files #16332
Conversation
167d389
to
37675eb
Compare
autotest: mark some vehicles as having external physics models autotest: add default_params_filename to some vehicle info
37675eb
to
1ba2a16
Compare
Most of the Copter frames are spitting the equivalent of this out:
|
we really need to add proper support for downloading defaults, preferably via ftp. The key would be to handle the ones where we do set_default() |
this is only for sitl params, right? For non-SITL we have a problem that SITL and non-SITL may have different defaults |
@tridge yes, this is for the SITL parameters represented in I've considered augmenting this to look at all of the files in |
A lot of fames are specifying EKF2 in their files where that's the default.
When we move to EKF3 by default that's a problem.
This tool does run on the other vehicle types, but the changes to their defaults are extensive so I've chosen to do a separate PR for those.
This new test is disabled at the moment but can be run with:
./Tools/autotest/autotest.py --gdb --debug build.Copter test.Copter.FrameDefaults