Implement parameter backup for 4.0 #16442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if header on primary parameter storage is corrupt then restore from backup
added params_restored error
not needed any more
|
I have done some light bench testing of this on a cubeorange and all seems fine but I'll continue with some more tests. |
peterbarker
approved these changes
Feb 5, 2021
| // header doesn't match. We can't recover any variables. Wipe | ||
| // the header and setup the sentinal directly after the header | ||
| Debug("bad header in setup - erasing"); | ||
| erase_all(); | ||
| } | ||
|
|
||
| // ensure that backup is in sync with primary | ||
| _storage_bak.copy_area(_storage); |
There was a problem hiding this comment.
Not checking return value here. Should probably be a flow-of-control internal error on failure.
In fact, copy_area should probably be void.
|
This will be released with Copter-4.0.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #16304 which implements the parameter backup system to resolve the parameter reset problem seen on some boards.
I don't know if there will be another 4.0.x release, but as some people are being badly affected by this issue I am making it available as a PR for easy use with 4.0.x releases.