Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GPS logging into AP_GPS #16579

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Move GPS logging into AP_GPS #16579

merged 3 commits into from
Feb 17, 2021

Conversation

peterbarker
Copy link
Contributor

No description provided.

@hendjoshsr71
Copy link
Member

Could also remove

ardupilot/libraries/AP_Logger/LogFile.cpp

Line 9 in 8058e8d

#include <AP_GPS/AP_GPS.h>

@peterbarker peterbarker force-pushed the pr/move-gps-logging branch 3 times, most recently from eb04063 to 6062899 Compare February 13, 2021 04:38
@peterbarker
Copy link
Contributor Author

As requested by @WickedShell , I've moved the logging functions from AP_GPS_Logging.cpp back into AP_GPS.cpp

@tridge
Copy link
Contributor

tridge commented Feb 16, 2021

need to test blended GPS logging works

@peterbarker
Copy link
Contributor Author

Blended GPS logging does work, at least in-as-far as the data in in GPS[2].Lat looks reasonable.

@peterbarker peterbarker merged commit dbdda65 into ArduPilot:master Feb 17, 2021
@peterbarker peterbarker deleted the pr/move-gps-logging branch February 17, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendjoshsr71 hendjoshsr71 hendjoshsr71 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterbarker @hendjoshsr71 @tridge @CraigElder