-
Notifications
You must be signed in to change notification settings - Fork 17.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send_position_target_global_int: Set mavlink altitude frame to be target's frame #17344
base: master
Are you sure you want to change the base?
Send_position_target_global_int: Set mavlink altitude frame to be target's frame #17344
Conversation
26fefbe
to
6311676
Compare
6311676
to
359e13a
Compare
I think this is probably most useful in Guided mode where the caller may want to check that what they've sent in has been consumed correctly. |
359e13a
to
6f8b7b5
Compare
6f8b7b5
to
50ce467
Compare
457fe6a
to
e1fb55d
Compare
Updated this so that the commanded altitude frames for guided and auto modes can also report relative to home in addition to terrain & absolute frames. Rover Autotest may fail: I think this is due to the issue with terrain in CI as it passes locally. There is an argument to be made that there isn't a lot of purpose to testing rover for differing altitude frames since it ignores altitude. |
d138f16
to
1645db5
Compare
1645db5
to
601a8ab
Compare
I've disabled the terrain frame autotest for now in this PR after fixing the altitude frame conversion in autotest. See this issue for why #18788 Mission Below: Sets Relative Frame 50m then 100m then 50m, Terrain 100m then 150m then 100m, then Absolute Frame 1200m then 1250m |
@peterbarker Any thoughts on disabling |
601a8ab
to
b1c8fa2
Compare
b1c8fa2
to
e391dff
Compare
e391dff
to
39ce23d
Compare
39ce23d
to
239d075
Compare
This changes the
send_position_target_global_int
message to send the target's altitude mavlink frame in the same frame as the target's location frame.Example: below uses waypoints in terrain, ASML, and above home frames.
Note this currently ends up being filled by AC_WP_Nav::get_wp_nav() which always sets the target to terrain or ASML. To get the above home frame filled in would require a bit work since that is not used in WP_Nav.
Master
After PR