Tools: correct passing arguments on Autotest.py #17554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
reviewed
May 25, 2021
Comment on lines
+144
to
+147
| j=j, | ||
| debug=debug, | ||
| math_check_indexes=math_check_indexes, | ||
| extra_args=extra_configure_args) |
There was a problem hiding this comment.
I wonder if we can do better here by keeping the arguments to configure and build as separate, opaque, objects.
ATM if we add something to the build options we'd have to go to each of the functions here and add that extra option in and then make sure we passed it into waf_configure. If instead we just passed the dict in we could waf_configure(board, **configure_opts) and not have (e.g.) build_tests have to know about what we were passing to configure.
tridge
approved these changes
May 26, 2021
|
approved by peter |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct argument for unittest and example
Display if debug is enable on configuration summary