-
Notifications
You must be signed in to change notification settings - Fork 17k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_RPM: Giving RPM some TLC #18044
AP_RPM: Giving RPM some TLC #18044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed on call, make 2_TYPE an enable param and add extra params for the 2nd instance
ac6e7b4
to
ca70a96
Compare
Recommend reviewing per commit as there are a few things in this PR. This PR now does the following:
|
ca70a96
to
6edbaf6
Compare
304aafc
to
0c0b7d1
Compare
0c0b7d1
to
2f1b807
Compare
Wiki update here: ArduPilot/ardupilot_wiki#3701 |
My apologies, I cannot attend the dev call but I think this PR is good to go. I would appriciate a review/potential merge. |
@Hwurzburg i already have a wiki pr to reflect these code changes. |
I will make it delay merge until this gets merged...and you make the minor edits ...thanks |
2f1b807
to
b3a4ae5
Compare
77087d8
to
538eb49
Compare
538eb49
to
c02cda1
Compare
Updated the param conversion note. Should be good to go once checks passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a minor fix to what I believe is just a hang over.
It looks like we create param arrays for _maximum, _minimum, and _quality_min yet we never give users the chance to set them on instances other than the 1st. This doesn't have any ploblems until we start trying to add more than two instances of RPM and immediatly follow on the param idx. Only noticed it whilst helping out @GiovannaAF trying to add more instances to RPM.
So we should either reduce the variable array size or add the _maximum, _minimum, and _quality_min params to the >1 instances of RPM IMHO. I opten for the former here: