New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move emit of primary-GPS-changed into AP_GPS #18163
Move emit of primary-GPS-changed into AP_GPS #18163
Conversation
1557602
to
d7ce59a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change
As discussed, let's initialise the primary value so we don't get a message in the log every time soon after startup. |
d7ce59a
to
2f88e7b
Compare
Incidentally, I'm kind of the opinion it would be OK to retain the current behaviour of logging a primary change if you're set up to not-auto-switch and not auto-switching. It's an atypical setup and we could save flash and complexity. |
I've added the requested change - so now we don't emit this message for any change on the first loop, which is what will happen if you both set Initialising the |
Oh. Tested in SITL by setting |
5f16901
to
4c7ed37
Compare
4c7ed37
to
10479a2
Compare
This wasn't really a sensor-health thing, either....
New addition to the blending test ensures we see the message come out in the log
This change will mean all vehicles can expect to see this event emitted.