Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invert SBUS on RC serial connections on F4 #18361

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Invert SBUS on RC serial connections on F4 #18361

merged 1 commit into from
Aug 19, 2021

Conversation

andyp1per
Copy link
Collaborator

@andyp1per andyp1per commented Aug 17, 2021 •
edited
Loading

Confirmed that this fixes SBUS on KakuteF4Mini:
https://discuss.ardupilot.org/t/futaba-r7008sb-not-working-on-kakute-f4-v2-mini/74872/26

Betaflight only uses active high, so other definitions were either missing or wrong.

@andyp1per andyp1per requested a review from tridge August 17, 2021 10:30
@andyp1per andyp1per mentioned this pull request Aug 17, 2021
Open
@Hwurzburg
Copy link
Collaborator

Hwurzburg commented Aug 17, 2021 •
edited
Loading

what about FPort , non telem connections? can this allow them to be used without an inverter on F4 also?
currently the wiki warns that Sbus and Fport need external inverters on F4s when using the serial port RC protocol....this eliminates that correct? how about the MatekF405 series?

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Aug 17, 2021
@andyp1per
Copy link
Collaborator Author

currently the wiki warns that Sbus and Fport need external inverters on F4s when using the serial port RC protocol....this eliminates that correct?

Correct on boards that have a HW inverter. As far as I can tell from the betaflight pinouts the matek board doesn't. The ones that do support it that we support are Diatone, Omnibus, Holybro, Revo, Sparky, iFlight, Airbot

@andyp1per
Copy link
Collaborator Author

It might help Fport if the inverter is on the TX as well

tridge
tridge requested changes Aug 18, 2021
View reviewed changes
libraries/AP_HAL_ChibiOS/UARTDriver.cpp Outdated Show resolved Hide resolved
@tridge tridge removed the DevCallEU label Aug 18, 2021
@andyp1per
AP_HAL_ChibiOS: use hardware serial inversion pins on F4 boards that …
4bd4e31 
…support it

change mamba F405 to active high as per betaflight
@andyp1per andyp1per requested a review from tridge August 18, 2021 07:53
@andyp1per
Copy link
Collaborator Author

@rmackay9 I think this should go into 4.1

@rmackay9
Copy link
Contributor

@andyp1per ok thanks. I've added this to the 4.1 projects for Copter, Plane, Rover.

@peterbarker peterbarker merged commit 0279c86 into ArduPilot:master Aug 19, 2021
@andyp1per andyp1per deleted the pr-sbus-invert branch August 19, 2021 07:11
@rmackay9 rmackay9 added this to pending in Copter 4.1 Aug 28, 2021
@rmackay9 rmackay9 moved this from pending to 4.1.0-beta8 in Copter 4.1 Aug 28, 2021
@Hwurzburg Hwurzburg removed the WikiNeeded needs wiki update label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge approved these changes

Assignees
No one assigned
Labels
AllVehicles BUG ChibiOS MergeOnCIPass
Projects
Copter 4.1
4.1.0-beta8
Plane 4.1
Awaiting triage
Rover 4.1
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andyp1per @Hwurzburg @rmackay9 @tridge @peterbarker