Stop sending sensor offsets mavlink message #18368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only works for first compass instance. We have all of these in parameters anyway.
Only works for first compass instance. We have all of these in parameters anyway.
Only works for first compass instance. We have all of these in parameters anyway.
Only works for first compass instance. We have all of these in parameters anyway.
Only works for first compass instance. We have all of these in parameters anyway.
Only works for first compass instance. We have all of these in parameters anyway.
Only works for first compass instance. We have all of these in parameters anyway.
|
Forget about my comment. I now read mavlink/mavlink#1453 and understand why you want to fully remove this message. |
WickedShell
approved these changes
Aug 17, 2021
|
|
||
| // run this message at a much lower rate - otherwise it | ||
| // pointlessly wastes quite a lot of bandwidth | ||
| if (send_sensor_offsets_counter++ < 10) { |
There was a problem hiding this comment.
Ha! This defeats a lot of the scheduling/buffering code as well because it's harder to land on the right order with stuff like this confusing the buffer backoffs :P
| mag_offsets.z, | ||
| compass.get_declination(), | ||
| barometer.get_pressure(), | ||
| barometer.get_temperature()*100, |
There was a problem hiding this comment.
This isn't actually available via the parameters, but it is in the scaled pressure, which is better anyways.
|
I certainly like the idea of reducing our telemetry bandwidth usage.. |
tridge
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only works for first compass instance.
We have all of these in parameters anyway.