Add options to prevent spamming Tuning Error messsages when not actually tuning or desired #18609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
approved these changes
Sep 8, 2021
peterbarker
reviewed
Sep 13, 2021
| @@ -49,7 +49,7 @@ const AP_Param::GroupInfo AP_Tuning::var_info[] = { | |||
|
|
|||
| // @Param: ERR_THRESH | |||
| // @DisplayName: Controller error threshold | |||
| // @Description: This sets the controller error threshold above which an alarm will sound and a message will be sent to the GCS to warn of controller instability | |||
| // @Description: This sets the controller error threshold above which an alarm will sound and a message will be sent to the GCS to warn of controller instability while tuning. The error is the rms value of the P+D corrections in the loop. High values in hover indicate possible instability due to too high PID gains or excessively high D to P gain ratios.-1 will disable this message. | |||
There was a problem hiding this comment.
Do we really sound an alarm?!
There was a problem hiding this comment.
do not know...dont have buzzers on my planes....
tridge
approved these changes
Sep 13, 2021
tridge
approved these changes
Sep 13, 2021
|
lgtm, @rmackay9 can you merge? |
|
AP_Tuning is not used by Copter so no problem for me, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents spamming tuning error messages if not actually actively tuning with TX tuning
Allows disabling messages entirely by setting error threshold to -1
Added metadata explanation of what message really means
and a drive-by bug fix to the rms calculations for Pitch pids that has been there since 2016