New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Airspeed move into AP_Vehicle #18838
AP_Airspeed move into AP_Vehicle #18838
Conversation
007448e
to
950d9d0
Compare
the saving of 208 bytes is suspicious |
950d9d0
to
7239b81
Compare
c326ae0
to
21ce4fb
Compare
Added conversion code for Rover & Sub including an AP_Param method to help with moving the whole sub-group. Turns out my previous method didn't work. However, there is an argument to be made that for Rover(Sailboats) & Sub that conversion for this may be overkill? |
21ce4fb
to
1cc6e08
Compare
@tridge If you have some time to help me with this it would be appreciated? It seems like a waf build system issue that I've been unable to solve yet. #define HAL_AIRSPEED_ENABLED APM_BUILD_TYPE(APM_BUILD_ArduPlane) || APM_BUILD_TYPE(APM_BUILD_Rover) || \
APM_BUILD_TYPE(APM_BUILD_ArduSub) || APM_BUILD_TYPE(APM_BUILD_Replay) |
9756565
to
a12bddb
Compare
I've tested this param conversion for Plane on a CubeOrange and all seems well. I also tested the param conversion for Rover and Sub in SITL. I've currently only set the HAL_AIRSPEED_ENABLED define for the vehicle libraries due to issues with APM_BUILD_TYPE. |
1e22f3d
to
1f4d076
Compare
Closing this as these commits were merged in #18813 |
This moves AP_Airspeed into AP_Vehicle as a basis for next adding airspeed into copter in this PR #18813
I could use a little help with the #ifdefs as I couldn't figure out a way to get everything I wanted without putting vehicle specific defines in AP_Airspeed.??
The biggest being Airspeed must be enabled for all vehicles & boards it is currently enabled on. And then be able to exclude APM_BUILD_ArduCopter being built-in by default.