AP_BattMonitor: use SOC 127 as an invalid SOC flag #19482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here, #19404 (comment)
Using soc = 101 for an invalid soc is pre-existing, but I'm not a fan of it. Technically, of course the battery can never get above 100 soc by definition both in current UAVCAN standard and of course reality. But if the system is misconfigured (wrong voltages, capacity, etc.) it could end up above 101 SOC.
I just looked some code for a UAVCAN battery monitor and it just sends out 100 if it computes SOC above 100. Instead IMO a device should send a "hey this is isn't right state using 127". Just a thought as we look to future DroneCan messages.
Since we can't really change the in-use UAVCAN standard I didn't propose that. I imagine the change would look like this in
1092.BatteryInfo.UAVCAN