AP_Terrain: avoid direct use of Location alt field #19922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested in SITL by using the "Terrain Check" option in MAVProxy and checking fields before/after this PR |
peterbarker
force-pushed
the
pr/terrain-relative-alt-use
branch
from
04e44b8
to
71596fd
Compare
peterbarker
force-pushed
the
pr/terrain-relative-alt-use
branch
from
71596fd
to
9ca360a
Compare
|
So this showed that we were using current_loc fields uninitialised. We're still using home even if it hasn't been set... |
This can happen at boot-time if the vehicle has no idea where it is
peterbarker
force-pushed
the
pr/terrain-relative-alt-use
branch
from
68991d0
to
cba9bd3
Compare
hendjoshsr71
approved these changes
Jan 31, 2022
tridge
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm really not sure about this whole returning of zero for above-home height if we don't know what it is. Perhaps we'd be better off not sending
TERRAIN_REPORTin that case - or a nan in the relevant mavlink field? Separate issue.