-
Notifications
You must be signed in to change notification settings - Fork 16.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ESCs constantly arming on rover with dshot commands #20374
Conversation
2ffa872
to
a8a048d
Compare
a8a048d
to
3b2b19c
Compare
@rmackay9 this appears to fix all of the bugs as far as I can tell including LED output. |
128cf20
to
95f102c
Compare
Thanks @rmackay9 should be fixed now. There were actually two remaining bugs, both of which were extremely subtle. |
make sure debug will compile take into account active channels when configuring bdshot add channel mask debug output correct set bdshot telemetry position at startup make sure all channels in a bdshot group are pulled high to prevent spurious pulses
disable channels that are not in use
unilaterally write rcoutput to appease the sitl gods
2db8051
to
f6c2909
Compare
Flown on a miniquad without issue - bi-directional dshot all ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this and it resolves the issues I was seeing on Rover, thanks very much!
This has been added to Copter-4.2.0-beta3 |
Several bugs fixed:
Although this affects all vehicles it will particularly help rover and plane