Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow individual Airspeed backends to be compiled out #20559

Merged

Conversation

peterbarker
Copy link
Contributor

No description provided.

@peterbarker
Copy link
Contributor Author

Everything still compiles, and we can compile each of the backends out separately or collectively.

@tridge
Copy link
Contributor

tridge commented May 1, 2022

test flown on a DroneCAN airspeed and MS4525 I2C today with no issues

@MallikarjunSE
Copy link
Contributor

Hey @peterbarker
define AP_AIRSPEED_BACKEND_DEFAULT_ENABLED 1 will enable all the drivers and 0 will pick defined driver?

@peterbarker
Copy link
Contributor Author

peterbarker commented May 2, 2022

Hey @peterbarker define AP_AIRSPEED_BACKEND_DEFAULT_ENABLED 1 will enable all the drivers and 0 will pick defined driver?

Not quite. You can still turn individual backends off if you set the default to 1, and in the second case it's truth that matters, not definition, when turning on a backend if the default has been set to 0.

Tools/scripts/build_options.py Outdated Show resolved Hide resolved
@peterbarker peterbarker force-pushed the recursion/pr/airspeed-per-backend-defines branch from 836fa45 to ba487d9 Compare May 4, 2022 08:07
@peterbarker peterbarker force-pushed the recursion/pr/airspeed-per-backend-defines branch from ba487d9 to 2476a3f Compare May 4, 2022 08:13
@peterbarker
Copy link
Contributor Author

pbarker@bluebottle:~/rc/ardupilot(pr/recursion-thing)$ cat /tmp/some.out | grep -i saves
Disabling analog(AP_AIRSPEED_ANALOG_ENABLED) on copter saves 288 bytes
Disabling analog(AP_AIRSPEED_ANALOG_ENABLED) on plane saves 288 bytes
Disabling analog(AP_AIRSPEED_ANALOG_ENABLED) on rover saves 280 bytes
Disabling analog(AP_AIRSPEED_ANALOG_ENABLED) on antennatracker saves -24 bytes
Disabling analog(AP_AIRSPEED_ANALOG_ENABLED) on sub saves 280 bytes
Disabling analog(AP_AIRSPEED_ANALOG_ENABLED) on blimp saves -16 bytes
Disabling ASP5033(AP_AIRSPEED_ASP5033_ENABLED) on copter saves 992 bytes
Disabling ASP5033(AP_AIRSPEED_ASP5033_ENABLED) on plane saves 992 bytes
Disabling ASP5033(AP_AIRSPEED_ASP5033_ENABLED) on rover saves 1008 bytes
Disabling ASP5033(AP_AIRSPEED_ASP5033_ENABLED) on antennatracker saves -24 bytes
Disabling ASP5033(AP_AIRSPEED_ASP5033_ENABLED) on sub saves 1008 bytes
Disabling ASP5033(AP_AIRSPEED_ASP5033_ENABLED) on blimp saves -24 bytes
Disabling DLVR(AP_AIRSPEED_DLVR_ENABLED) on copter saves 928 bytes
Disabling DLVR(AP_AIRSPEED_DLVR_ENABLED) on plane saves 928 bytes
Disabling DLVR(AP_AIRSPEED_DLVR_ENABLED) on rover saves 936 bytes
Disabling DLVR(AP_AIRSPEED_DLVR_ENABLED) on antennatracker saves -24 bytes
Disabling DLVR(AP_AIRSPEED_DLVR_ENABLED) on sub saves 936 bytes
Disabling DLVR(AP_AIRSPEED_DLVR_ENABLED) on blimp saves -16 bytes
Disabling MS4525(AP_AIRSPEED_MS4525_ENABLED) on copter saves 1704 bytes
Disabling MS4525(AP_AIRSPEED_MS4525_ENABLED) on plane saves 1704 bytes
Disabling MS4525(AP_AIRSPEED_MS4525_ENABLED) on rover saves 1712 bytes
Disabling MS4525(AP_AIRSPEED_MS4525_ENABLED) on antennatracker saves -24 bytes
Disabling MS4525(AP_AIRSPEED_MS4525_ENABLED) on sub saves 1712 bytes
Disabling MS4525(AP_AIRSPEED_MS4525_ENABLED) on blimp saves -16 bytes
Disabling MS5525(AP_AIRSPEED_MS5525_ENABLED) on copter saves 1672 bytes
Disabling MS5525(AP_AIRSPEED_MS5525_ENABLED) on plane saves 1672 bytes
Disabling MS5525(AP_AIRSPEED_MS5525_ENABLED) on rover saves 1680 bytes
Disabling MS5525(AP_AIRSPEED_MS5525_ENABLED) on antennatracker saves -24 bytes
Disabling MS5525(AP_AIRSPEED_MS5525_ENABLED) on sub saves 1680 bytes
Disabling MS5525(AP_AIRSPEED_MS5525_ENABLED) on blimp saves -16 bytes
Disabling MSP(AP_AIRSPEED_MSP_ENABLED) on copter saves 560 bytes
Disabling MSP(AP_AIRSPEED_MSP_ENABLED) on plane saves 560 bytes
Disabling MSP(AP_AIRSPEED_MSP_ENABLED) on rover saves 552 bytes
Disabling MSP(AP_AIRSPEED_MSP_ENABLED) on antennatracker saves -8 bytes
Disabling MSP(AP_AIRSPEED_MSP_ENABLED) on sub saves 552 bytes
Disabling MSP(AP_AIRSPEED_MSP_ENABLED) on blimp saves 0 bytes
Disabling NMEA(AP_AIRSPEED_NMEA_ENABLED) on copter saves -72 bytes
Disabling NMEA(AP_AIRSPEED_NMEA_ENABLED) on plane saves -72 bytes
Disabling NMEA(AP_AIRSPEED_NMEA_ENABLED) on rover saves 880 bytes
Disabling NMEA(AP_AIRSPEED_NMEA_ENABLED) on antennatracker saves -24 bytes
Disabling NMEA(AP_AIRSPEED_NMEA_ENABLED) on sub saves 880 bytes
Disabling NMEA(AP_AIRSPEED_NMEA_ENABLED) on blimp saves -16 bytes
Disabling SDP3X(AP_AIRSPEED_SDP3X_ENABLED) on copter saves 2312 bytes
Disabling SDP3X(AP_AIRSPEED_SDP3X_ENABLED) on plane saves 2312 bytes
Disabling SDP3X(AP_AIRSPEED_SDP3X_ENABLED) on rover saves 2312 bytes
Disabling SDP3X(AP_AIRSPEED_SDP3X_ENABLED) on antennatracker saves -24 bytes
Disabling SDP3X(AP_AIRSPEED_SDP3X_ENABLED) on sub saves 2312 bytes
Disabling SDP3X(AP_AIRSPEED_SDP3X_ENABLED) on blimp saves -16 bytes
Disabling UAVCAN(AP_AIRSPEED_UAVCAN_ENABLED) on copter saves 2448 bytes
Disabling UAVCAN(AP_AIRSPEED_UAVCAN_ENABLED) on plane saves 2464 bytes
Disabling UAVCAN(AP_AIRSPEED_UAVCAN_ENABLED) on rover saves 2464 bytes
Disabling UAVCAN(AP_AIRSPEED_UAVCAN_ENABLED) on antennatracker saves 1856 bytes
Disabling UAVCAN(AP_AIRSPEED_UAVCAN_ENABLED) on sub saves 2464 bytes
Disabling UAVCAN(AP_AIRSPEED_UAVCAN_ENABLED) on blimp saves 352 bytes
Disabling AIRSPEED(AP_AIRSPEED_ENABLED) on copter saves 17512 bytes
Disabling AIRSPEED(AP_AIRSPEED_ENABLED) on plane saves 19624 bytes
Disabling AIRSPEED(AP_AIRSPEED_ENABLED) on rover saves 18496 bytes
Disabling AIRSPEED(AP_AIRSPEED_ENABLED) on antennatracker saves 2440 bytes
Disabling AIRSPEED(AP_AIRSPEED_ENABLED) on sub saves 16968 bytes
Disabling AIRSPEED(AP_AIRSPEED_ENABLED) on blimp saves 2408 bytes
pbarker@bluebottle:~/rc/ardupilot(pr/recursion-thing)$ 

@tridge tridge merged commit 74ca672 into ArduPilot:master May 9, 2022
@peterbarker peterbarker deleted the recursion/pr/airspeed-per-backend-defines branch May 15, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants