Correct compilation when most features out, one in #21878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/test-build-options-enable-in-turn
branch
2 times, most recently
from
1e1e36d
to
79a80e0
Compare
peterbarker
commented
Oct 5, 2022
peterbarker
force-pushed
the
pr/test-build-options-enable-in-turn
branch
from
79a80e0
to
51c1365
Compare
takes forever and takes extra options to pass
neither of these are relevant to the ChibiOS builds and the dafult for ChibiOS (disabled) is appropriate.
similar to what we do elsewhere, just grab the singleton in the cpp file rather than taking a pointer to it
This requires AP_SIM_ENABLED, which is not available in build_options.py yet.
peterbarker
force-pushed
the
pr/test-build-options-enable-in-turn
branch
from
51c1365
to
a634323
Compare
tridge
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature to
test_build_options.pywhich disables all features except one feature and its dependencies.This PR also contains fixes for various problems found by this new test - mostly build_options.py dependencies, but also some transitive-include bugs.