-
Notifications
You must be signed in to change notification settings - Fork 17.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Scripting: added fixed wing boost motor example #22585
base: master
Are you sure you want to change the base?
Conversation
allow for extra motor to be used when at high throttle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not checking safety switch state. And probably several other ways we usually stop motors turning (throttle suppression? eSTOP?).
That might be OK, but we should definitely call it out in a comment!
safety switch will still work, doesn't need special handling as it impacts all outputs other than masked ones. Adding any check for it would be incorrect |
0c25b58
to
2b1c6c9
Compare
I would hard code this to use one of the "motor" output functions. |
we can't use k_boost_throttle as AP_MotorsMulticopter already outputs to it
E-stop is extremely rare on quadplanes (I can't recall seeing a log with it enabled) |
we need to add a k_ThrottleRaw which is the throttle before the ICE override, so that when the ICE engine dies we don't kill the booster. When using k_throttle the booster would stop as the ICE engine would go into re-start, which drops the throttle that the booster uses in this script |
This is for aircraft using an ICE fwd engine with an electric boost motor