AP_Generator: rename fuel_remain_pct to fuel_remain_scale #23168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/fuel-remain-pct
branch
3 times, most recently
from
ee5013e
to
acdc64d
Compare
peterbarker
changed the title
|
Not gonna argue with fixing a bug. I would probably prefer something that moves towards keeps things in percent since we already have functions for remaining_pct? |
rmackay9
reviewed
Mar 14, 2023
| @@ -40,7 +40,7 @@ void AP_Generator_IE_650_800::assign_measurements(const uint32_t now) | |||
| _err_code = _parsed.err_code; | |||
|
|
|||
| // Update variables to be returned to front end | |||
| _fuel_remain_pct = _parsed.tank_pct * 0.01; | |||
There was a problem hiding this comment.
Discussed on the dev call and the decision was to remove the suffix or use "_proportion". I'm happy with either these ideas.
peterbarker
force-pushed
the
pr/fuel-remain-pct
branch
from
acdc64d
to
872b4cf
Compare
Only fixing the AP_Generator interface here :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a scale, not a percentage.
It's used as such and commented as such.
This has caused at least one bug.
This work sponsored by Harris Aerial