Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iFlight Blitz F745 AIO #23985

Merged
merged 3 commits into from Jun 28, 2023
Merged

iFlight Blitz F745 AIO #23985

merged 3 commits into from Jun 28, 2023

Conversation

tiralonghipol
Copy link
Contributor

@tiralonghipol tiralonghipol commented Jun 6, 2023

Support for iFlight BlitzF7

@tiralonghipol
Copy link
Contributor Author

@andyp1per
Any further test I can run?

@andyp1per
Copy link
Collaborator

I think I have most things working now - please give it a try and see how you get on

@tiralonghipol
Copy link
Contributor Author

awesome I have some time over the weekend

@andyp1per andyp1per changed the title Dev/blitz f7 iFlight Blitz F7 Jun 8, 2023
@andyp1per
Copy link
Collaborator

any news on the testing?

@tiralonghipol
Copy link
Contributor Author

Got a bit delayed, it is the first thing in my todo list tomorrow!

@tiralonghipol
Copy link
Contributor Author

tiralonghipol commented Jun 19, 2023

looks good on the desk!
steps/procedure:

  • brand new board
  • git pull latest dev/Blitz branch
  • build and flash bootloader (with updated board id)
  • build and flash firmware
  • rc setup on serial3, correctly interfaced with FrSky Taranis xLite-s
  • arming/disarming works after rc switch mapping
  • reversed motors wrong direction usin fc passthrough and esc-configurator
  • using dShot300 cause apparently 1200 is not supported
    I also updated the escs with latest blueJay firmware and frq to 48khz

questions:
should the rgb led blink or signal anything specific? I do not see any activity

Next step: mount props and fly
kenny_ardupilot

@andyp1per
Copy link
Collaborator

The neopixel LED should blink but mine does not either - I double checked everything so I wonder if the betaflight pinout is wrong somehow

@tiralonghipol
Copy link
Contributor Author

I cant find issues
Better tuning required of course
quick flight test: https://www.youtube.com/watch?v=QcnAWToGpGQ

@andyp1per
Copy link
Collaborator

Great! - did the motor order come out right?

@tiralonghipol
Copy link
Contributor Author

tiralonghipol commented Jun 19, 2023

using the betaflight convention yes:

4   1
  x
3   2

for some reason the pitch was inverted (channel 1 in my case)
the radio has all signals normal, so I just reversed ch1 and it works

@andyp1per
Copy link
Collaborator

pitch is always inverted on AP - blame history

@andyp1per
Copy link
Collaborator

Thanks for the testing. I will update the board ids and have one last go at getting the LED to work and then get it merged.

@tiralonghipol
Copy link
Contributor Author

tiralonghipol commented Jun 19, 2023

one never stop learning I guess
thank you so much for your help!

@andyp1per
Copy link
Collaborator

I can't make the neopixel work :( my guess is its mislabeled and will require help from iFlight to correct

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Jun 19, 2023
@Hwurzburg
Copy link
Collaborator

I am going to need some time to work thru the README and defaults.....several things do not look right....will try to do it early this week

@andyp1per
Copy link
Collaborator

Yeah sorry, have not actually looked at the README - will have a go today.

In other news the neopixel does not work on Betaflight either - so there is a fundamental problem with the config

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have started looking at this...these files are misnamed and will cause user confusion...this HWDEF is is for the BLITZ Whoop F7 AIO specifically ....other Flight Blitz F7 boards CANNOT use this....please rename this BlitzF7WhoopAIO or similar....will continue to review this weekend ...but this is basic and involves a lot of renaming, so I mention this first

@andyp1per
Copy link
Collaborator

How about BlitzF745AIO ? Distinguishes from teh F722 Blitz's and the non-ESC versions.

libraries/AP_HAL_ChibiOS/hwdef/BlitzF7/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/BlitzF7/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/BlitzF7/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/BlitzF7/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/BlitzF7/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/BlitzF7/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/BlitzF7/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/BlitzF7/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/BlitzF7/README.md Outdated Show resolved Hide resolved
@Hwurzburg
Copy link
Collaborator

How about BlitzF745AIO ? Distinguishes from teh F722 Blitz's and the non-ESC versions.

sounds fine to me

@andyp1per andyp1per changed the title iFlight Blitz F7 iFlight Blitz F745 AIO Jun 26, 2023
@andyp1per andyp1per force-pushed the dev/BlitzF7 branch 2 times, most recently from a8c871b to 6fd25bd Compare June 26, 2023 16:57
@tridge
Copy link
Contributor

tridge commented Jun 26, 2023

@andyp1per why marked for dev call when you haven't approved?

@Hwurzburg
Copy link
Collaborator

also was agreed that someone (you preferably) put in funding req to get one of these for future support/issues

@andyp1per
Copy link
Collaborator

@andyp1per why marked for dev call when you haven't approved?

Apologies, I was forgetting this was not my PR - we were going to merge last week and then some changes were asked for. This is the redo

Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really qualified but others have approved so LGTM.

@rmackay9 rmackay9 dismissed stale reviews from peterbarker and tridge June 28, 2023 07:22

Board ID changed so dismissing this review.

@rmackay9 rmackay9 merged commit 75afe88 into ArduPilot:master Jun 28, 2023
41 checks passed
@rmackay9 rmackay9 added this to Pending in Copter-4.4 Jul 3, 2023
@andyp1per andyp1per mentioned this pull request Jul 27, 2023
@rmackay9 rmackay9 moved this from Pending to 4.4.0-beta4 in Copter-4.4 Jul 27, 2023
@rmackay9
Copy link
Contributor

With AndyP's help this has been included in Copter-4.4.0-beta4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Copter-4.4
4.4.0-beta4
Development

Successfully merging this pull request may close these issues.

None yet

9 participants