New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow scaled passthru to go to trim on rc failsafe #24036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need per channel options? Would one bit for all in RC_OPTIONS
work?
No...could have some pass thru things like airbrakes/slats...lights...etc that you want to stay unchanged while in fs also |
Another option instead of a new parameter is to add another bunch of 16 scaled output functions for "RC in scaled trim in FS". But I tend to think were getting a little too niche for most users and might be better just to say use scripting at this point. For example what if I want my scaled output to go to min or max on failsafe, should we add more parameters for that? |
18eb384
to
0377fe9
Compare
scripting is not available on many popular autopilots.....the F4 class is resurging with the new Chinese cpus also |
I guess a alternative would be to still update rc in while in failsafe. Then you could set your failsafe positions in the transmitter and have them passed through. |
Not a solution for rc failure failsafes...that is why we recommend using no pulses |
SITL and board tested |
Would fixing #24093 remove the need for this PR? |
no...thats gimbal....and this PR actually stimulated that for the Gimbal library...this covers nonGimbal library applications...ie just a couple of servos which are pilot only controlled |
6372f9a
to
a9e7ba8
Compare
In general this looks OK to me. I worry a little about scope creep going forward and the leak of failsafe actions out of the vehicle code and into the libraries. |
Allows selecting any scaled passthru channel to go to input trim on rc failsafe instead of freezing
Allows pilot controlled gimbals to revert to forward position while returning to home
builds off some of @peterbarker work