Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Mount: Viewpro date fix (and other small fixes) #24788

Merged
merged 3 commits into from Aug 29, 2023

Conversation

rmackay9
Copy link
Contributor

@rmackay9 rmackay9 commented Aug 28, 2023

This makes 3 unrelated fixes to AP's camera and mount subsystems found during recent testing. These changes have been tested on real hardware.

  1. Viewpro driver fix to the date sent to the camera gimbal. The mask applied to the date was incorrect meaning it was incorrect after the 15th of the month. Below is a screenshot of the Viewlink app showing the correct date after this PR was applied.
    image
  2. AP_Mount's DEVID field should be writeable so that users can reset it to zero in case they swap one Xacti camera for another (assuming the other has a different DroneCAN node id).
  3. RC_Channel's init_aux_function was missing entries for the recently added CAMERA_IMAGE_TRACKING and CAMERA_LENS features. For image tracking we don't need to initialise the state but for set-lens we should.
    image
    image

@tridge tridge merged commit c733872 into ArduPilot:master Aug 29, 2023
84 checks passed
@rmackay9 rmackay9 deleted the viewpro-date-fix branch August 29, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants