Allow more libraries to compile with no HAL_GCS_ENABLED #24860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/more-no-hal-gcs
branch
5 times, most recently
from
606383c
to
ebfdddd
Compare
peterbarker
force-pushed
the
pr/more-no-hal-gcs
branch
from
ebfdddd
to
4bb1dc3
Compare
tridge
approved these changes
Sep 5, 2023
|
Feel free to update the Xacti driver when you're ready. No need to hold up this PR of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... useful when putting libraries onto periph.
Useful if you want to compile a vehicle with no GCS....
Everything compiles with no changes (had to create #24859 to get around iomcu dshot bootloader build issues)
No vehicles were modified here. Those are separate discussions...
I've run this through the
test_build_options.pyscript and everything passed there.