AP_OSD:add Aviation style AH option #24934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
previously requested changes
Sep 10, 2023
|
Should we have the flashing line all the time no mater the pitch inversion? Personally I think this option is more intuitive, I would be tempted to make it the default. |
|
yeah, I already made that change for default betaflight display, just havent pushed it yet....in a few minutes I am on the fence about defaulting it....its not a good experience when overlaid on video, the reason Betaflight/MWMOSD chose this to begin with.... but its easier to fly inverted with no video....whatever the group decides I think |
IamPete1
reviewed
Sep 11, 2023
peterbarker
reviewed
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add inverted flight indication (flashing horizon line) and reverses horizon movement when inverted....currently an option in this PR but we may want to make it the default mode even if its a change in behavior...or just change to it instead of the current Betaflight copied behavor...I think that having the option but defaulting it is probably best, but dont have strong feelings either way
tested in SITL
https://youtu.be/RZamcZy_5Zs