Feature/rover enum class #25066
Merged
Feature/rover enum class #25066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
reviewed
Sep 22, 2023
rmackay9
approved these changes
Sep 22, 2023
|
I've added to the Dev call but we could potentially merge before then. @peterbarker or @IamPete1 may want to review as well although no big pressure. |
khancyr
force-pushed
the
feature/rover_enum_class
branch
from
b883959
to
45d2d82
Compare
peterbarker
approved these changes
Sep 26, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a bit of enum class on Rover.
Override #20011
gain some space
Add missing TERMINATE handler for fence breach and FS