AP_TempratureSensor: add support for analog sensor with polynomial #25152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
reviewed
Oct 3, 2023
rmackay9
approved these changes
Oct 3, 2023
peterbarker
approved these changes
Oct 3, 2023
|
It would be nice to get @magicrub's approval if he's tested. |
magicrub
previously requested changes
Oct 3, 2023
|
@rmackay9 I don't have a sensor to test with. |
peterbarker
previously requested changes
Oct 3, 2023
magicrub
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
LGTM.. although I'm not in favor of the name, it feels misleading. It's not just "analog", it's specific to a type of signal that is output by a specific sensor. It's not just a plain old analog voltage like we've used in rangefinder and battery stuff in the past.
|
@magicrub I'm open to better suggestions. The analog range finder has a offset and a scale factor, that is the first two params of our polynomial. It also has a param for a fit type, "LINEAR", "INVERTED" and "HYPERBOLA". I don't think this is so different to that. |
tridge
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is sponsored by Spektreworks.
This adds support for a analog voltage temperature sensor. It uses a 4th order polynomial to go from voltage to temperature for use with thermistors. Because of the 5 polynomial terms and the pin this adds a var pointer param table to AP_TempratureSensor like those in battery and rangefinder.