AP_Scripting: Fix Location desc method needing AHRS #25225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is blocking PR #25226 |
|
This fix is included in #25183 I would think you would need the depends on the whole AHRS singleton also (as in my PR)? |
|
@IamPete1 your change looks good and adding it to AHRS itself is not a bad idea but not required to fix the periph-heavy build that this minor change is solving. |
magicrub
force-pushed
the
pr/scripting_desc_location_ahrs
branch
from
72acd79
to
4d035be
Compare
|
already part of PR #25183 which has merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a build error where Scripting is enabled but AHRS is not.. such as AP_Periph
Location::get_vector_from_origin_NEU(Vector3f) is wrapped in AP_AHRS_ENABLED which it needs.